Re: [PATCH v2 1/7] clk: Add a generic clock infrastructure

Hi Mike,

Some random comments/nits ...

On Thu, Sep 22, 2011 at 03:26:56PM -0700, Mike Turquette wrote:

+struct clk *clk_register(const struct clk_hw_ops *ops, struct clk_hw *hw,

• const char *name)
  

+{

• struct clk *clk;
• clk = kzalloc(sizeof(*clk), GFP_KERNEL);
• if (!clk)

• return NULL;
  

• INIT_HLIST_HEAD(&clk->children);
• INIT_HLIST_NODE(&clk->child_node);

The children and child_node are introduced in patch #2, and should not be used in patch #1.

• clk->name = name;
• clk->ops = ops;
• clk->hw = hw;
• hw->clk = clk;
• /* Query the hardware for parent and initial rate */
• if (clk->ops->get_parent)

• /* We don't to lock against prepare/enable here, as
  

•  * the clock is not yet accessible from anywhere */
  

/* * Multiple line comments */

• clk->parent = clk->ops->get_parent(clk->hw);
  

• if (clk->ops->recalc_rate)

• clk->rate = clk->ops->recalc_rate(clk->hw);
  

One blank line is good enough.

• return clk;

+}